| Subject: | This seems to be linked from an... |
|---|
| Summary: | Package rating comment |
|---|
| Messages: | 1 |
|---|
| Author: | lewis cowles |
|---|
| Date: | 2015-01-24 21:15:12 |
|---|
| |
|
|
lewis cowles rated this package as follows:
| Utility: | Insufficient |
|---|
| Consistency: | Sufficient |
|---|
| Examples: | Not sure |
|---|
|
|
 lewis cowles - 2015-01-24 21:15:12 This seems to be linked from an external library in places with no credit given to that library. Also while I would say that it is a better effort than bare-metal PDO, it needs a lot of work. Specifically, it does not offer any benefit other than programatically building a limited subset of SQL, naive transactions, which I do not think is the job of the PDO Model.
Things to improve this would be static $connection(extending PDO) passed by reference to a method setConnection to allow overall model (not instance) connection, perhaps defaulting to ConnectionManager. This way the model and it's data are decoupled from a single data-store.
Other improvements:
* Remove obvious coupling with PDO oddities by introducing standard dsn constants
* force UTF-8 & prepared statements (can still be string built, just requires engineering)
* Use namespaces
|
